sink/mysql: support translated to insert SQL if old value enabled #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-integration-tests tidb=release-4.0 tikv=release-4.0 pd=release-4.0 |
|
/run-integration-tests tidb=release-4.0 tikv=release-4.0 pd=release-4.0 |
|
LGTM |
|
/run-integration-tests tidb=release-4.0 tikv=release-4.0 pd=release-4.0 |
|
/lgtm |
ti-srebot
approved these changes
Sep 16, 2020
|
/run-integration-tests tidb=release-4.0 tikv=release-4.0 pd=release-4.0 |
Codecov Report
@@ Coverage Diff @@
## master #955 +/- ##
================================================
+ Coverage 33.5889% 33.6204% +0.0315%
================================================
Files 100 100
Lines 11998 12073 +75
================================================
+ Hits 4030 4059 +29
- Misses 7573 7615 +42
- Partials 395 399 +4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In MySQL sink, insert is translated to REPLACE SQL, update is translated to DELETE + REPLACE SQL
When old value feature is enabled, we can distinguish whether a SQL is update or insert, so we can translate insert to INSERT SQL and update to UPDATE SQL to increase executing performance.
But in some cases,
updateandinsertis not reentrant, we also need thesafe-modemechanism to force write data.Besides, the more convenient
safe-modeswitch will be implemented in another PR.What is changed and how it works?
safe-modeoption in MySQL sinkCheck List
Tests
Release note